CLN: #1836 merge `pyrefly_strict` into `pyrefly`, make `ty_all` and `pyrefly_all` passing by cmp0xff · Pull Request #1867 · pandas-dev/pandas-stubs

cmp0xff · 2026-08-02T17:46:58Z

Addresses TST: "strict" modes for mypy, pyrefly and ty #1836 (Replace xxxx with the Github issue number)
Tests added (Please use assert_type() to assert the type of any return value)
If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

styler

fix: categorical

….pyi` (#1871) * `@override` in `Timestamp` * one more override * fix run

Dr-Irv

did go through the tests, so those are reviewed.

There is one open comment from previous review - others were all resolved.

Dr-Irv · 2026-08-18T15:33:17Z

-    @override
-    def nbytes(self) -> int: ...
-    @property
    def size(self) -> int: ...


I think you can remove size here

Dr-Irv · 2026-08-18T15:43:16Z

+    @override
+    # pyrefly: ignore[bad-override]
+    def isin(self, values: Iterable[Any], level: Level) -> np_1darray_bool: ...


Yes, but the code defines isin allowing None as the argument for level here:
https://github.com/pandas-dev/pandas/blob/4e1b1f77dbc700e505c808e8b6bc164abce87955/pandas/core/indexes/multi.py#L4884

So I think we can delete this override and the tests should still work.

Dr-Irv · 2026-08-18T15:46:43Z

+    @override
    def set_names(


OK - the implementation is just in Index, but tests for MultiIndex being required if Mapping is the argument

Dr-Irv · 2026-08-18T15:56:00Z


    def my_named_func_1(df: pd.DataFrame) -> pd.Series[str]:
-        return df["a"]
+        return cast("pd.Series[str]", df["a"])


can we add a comment here why we're OK with the cast in the test?

Dr-Irv · 2026-08-18T15:58:02Z


    def sum_mean(x: pd.DataFrame) -> float:
-        return x.sum().mean()
+        return cast("pd.Series[float] | pd.Series[int]", x.sum()).mean()


Not a fan of the cast here. Why should a user be required to do the cast to get this to work?

ty reveals x.sum() as Series[Any], and Series[Any]().mean() as Unknown. What do you think? We can make Series[Any]().mean() giving Any.

At least for pyright, x.sum().mean() is revealed as float there. So check the other type checkers, as this might be a bug in ty

Dr-Irv · 2026-08-18T16:00:46Z

        return Series(val)

-    def s2scalar(val: Series) -> float:
+    def s2scalar(val: Series[int] | Series[float]) -> float:


same comment as above

Dr-Irv · 2026-08-18T16:02:06Z

Multiple places here (I didn't comment on all of them), but we want functions declared as:

def foo(val: Series) -> float:

to be acceptable usage. We can't force people to use the generic declarations like Series[int] and Series[float].

Is there a way to keep the tests as they were?

Dr-Irv · 2026-08-18T16:03:01Z

same comment here as in test_groupby.py about the function declarations

Dr-Irv · 2026-08-18T16:05:49Z

DatetimeIndexResampler is not documented, so I don't think we should use it in tests. Also, have functions with Series[int] in declaration, but we can't expect users to do that.

Based on the asserts, I think DatetimeIndexResampler is indeed needed for typing purposes 😕 #848

I think those assert should be removed.

But I also think that in pandas, DatetimeIndexResampler, PeriodIndexResampler and TimedeltaIndexResampler should be added to the pandas.api.typing module since pandas.api.typing.DataFrameGroupBy.resample can return those types.

Created pandas-dev/pandas#66850

Dr-Irv · 2026-08-18T16:07:22Z

same comment about having functions with Series[int] | Series[float] as argument types

cmp0xff force-pushed the pyrefly-strict-ty-all branch 2 times, most recently from 2232058 to 461372e Compare August 2, 2026 23:10

This was referenced Aug 3, 2026

TYP: #1867 Categorical #1869

Merged

CLN: #1867 Styler #1870

Merged

TYP: #1447 #1867 @override in pandas-stubs/_libs/tslibs/timestamps.pyi #1871

Merged

cmp0xff force-pushed the pyrefly-strict-ty-all branch 7 times, most recently from 0122fa5 to 2770692 Compare August 5, 2026 21:26

loicdiridollou pushed a commit that referenced this pull request Aug 5, 2026

CLN: #1867 Styler (#1870)

a1b30f5

styler

cmp0xff force-pushed the pyrefly-strict-ty-all branch 2 times, most recently from 497906a to c3e92f5 Compare August 5, 2026 22:27

loicdiridollou pushed a commit that referenced this pull request Aug 6, 2026

TYP: #1867 Categorical (#1869)

2d0fa7e

fix: categorical

cmp0xff force-pushed the pyrefly-strict-ty-all branch from c3e92f5 to bd902dc Compare August 6, 2026 07:32

cmp0xff mentioned this pull request Aug 6, 2026

BUG: relocate to_offset and other pyrefly-inspired changes #1878

Merged

3 tasks

cmp0xff force-pushed the pyrefly-strict-ty-all branch from 642ad36 to 24d0eff Compare August 6, 2026 09:30

loicdiridollou pushed a commit that referenced this pull request Aug 6, 2026

TYP: #1447 #1867 @override in `pandas-stubs/_libs/tslibs/timestamps…

db718c4

….pyi` (#1871) * `@override` in `Timestamp` * one more override * fix run

cmp0xff force-pushed the pyrefly-strict-ty-all branch 2 times, most recently from d661339 to 51fbbbc Compare August 6, 2026 15:18

cmp0xff mentioned this pull request Aug 6, 2026

CLN: #1878 disable pyright reportUnknownLambdaType and pyrefly implicity-any-lambda #1879

Merged

3 tasks

cmp0xff force-pushed the pyrefly-strict-ty-all branch 3 times, most recently from 4279c42 to 040bab0 Compare August 13, 2026 21:59

cmp0xff mentioned this pull request Aug 14, 2026

CLN: #1867 SeriesGroupBy.aggregate #1894

Merged

3 tasks

cmp0xff force-pushed the pyrefly-strict-ty-all branch from f2723c4 to 299ad19 Compare August 14, 2026 11:44

cmp0xff changed the title ~~CLN: #1836 merge pyrefly_strict into pyrefly, ty_all into ty~~ CLN: #1836 merge pyrefly_strict into pyrefly, make ty_all passing Aug 14, 2026

cmp0xff changed the title ~~CLN: #1836 merge pyrefly_strict into pyrefly, make ty_all passing~~ CLN: #1836 merge pyrefly_strict into pyrefly, make ty_all and pyrefly_all passing Aug 14, 2026

cmp0xff added 23 commits August 18, 2026 14:28

is_unique

8f88636

is_monotonic_decreasing

29e7139

is_monotonic_increasing

e36f014

hasnans

e1b0a93

inferred_type

1a7316f

tzinfo

502146e

memory_usage

95df327

get_loc

7070859

__len__

54c6463

dropna

57669a8

nlevels

74bb14b

has_duplicates

e3c9cdc

size

a4e3e6e

remove NoNewAttributesMixin

88140bd

empty

4ab74f9

ndim

a55eb5c

searchsorted

2585225

nunique

7a2b5a5

to_list

55826f5

Iterator[DataFrame]

6593909

_BaseVersion

47997fd

mod and rmod

c5906ac

tolist

adb12c6

cmp0xff requested a review from Dr-Irv August 18, 2026 13:49

Dr-Irv requested changes Aug 18, 2026

View reviewed changes

cmp0xff added 4 commits August 18, 2026 23:50

Merge remote-tracking branch 'upstream' into pyrefly-strict-ty-all

c396d44

MultiIndex.isin

425c2d9

size

81d1218

one less cast

e953198

Dr-Irv mentioned this pull request Aug 19, 2026

ENH: add DatetimeIndexResampler, PeriodIndexResampler and TimedeltaIndexResampler to pandas.api.typing pandas-dev/pandas#66850

Open

3 tasks

Uh oh!

Uh oh!

Conversation

cmp0xff commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr-Irv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cmp0xff commented Aug 2, 2026 •

edited

Loading